Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update asv version. #86

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
+16 −8
Open

Update asv version. #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e9fc0d1
Update asv version.
smithdc1 Oct 17, 2024
b40805f
Updated actions versions.
smithdc1 Oct 17, 2024
41e200c
Unpin conda version.
smithdc1 Oct 17, 2024
9b2ce08
Added "build" dependency.
smithdc1 Oct 17, 2024
dcbebd9
Revert "Added "build" dependency."
smithdc1 Oct 17, 2024
bd41fc8
Installed conda-build.
smithdc1 Oct 17, 2024
3e8258b
Added conda environment file with dependencies for asv build commands…
smithdc1 Oct 17, 2024
086b73b
Revert "Installed conda-build."
smithdc1 Oct 17, 2024
0573568
Use conda-incubator to setup the conda environment.
smithdc1 Oct 18, 2024
65e734a
List conda packages.
smithdc1 Oct 18, 2024
1fd8d8f
Use existing conda environment.
smithdc1 Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
- uses: actions/setup-python@v4
uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.11'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python-version: '3.11'
python-version: '3.12'

It seems ASV support Python 3.12 since version 0.6.2.

- name: Pull Changes
Expand All @@ -23,21 +23,23 @@ jobs:
- name: Setup Miniforge
uses: conda-incubator/setup-miniconda@v3
with:
miniforge-version: "24.1.2-0"
activate-environment: asv-bench
environment-file: environment.yml
- name: Install Requirements
run: pip install -r requirements.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: pip install -r requirements.txt
run: python -m pip install --requirement requirements.txt

Using pip as module is a best practice, and also long form for attributes.

- name: Cache Django
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: Django/*
key: Django
- name: Run Benchmarks
shell: bash -l {0}
run: |-
conda info
conda list
asv machine --machine ubuntu-latest --yes
echo '```' >> $GITHUB_STEP_SUMMARY
asv continuous --interleave-processes -a processes=2 --split --show-stderr 'HEAD^' 'HEAD' |\
asv continuous -E conda:asv-bench --interleave-processes -a processes=2 --split --show-stderr 'HEAD^' 'HEAD' |\
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
asv continuous -E conda:asv-bench --interleave-processes -a processes=2 --split --show-stderr 'HEAD^' 'HEAD' |\
asv continuous --environment conda:asv-bench --interleave-processes --attribute processes=2 --split --show-stderr 'HEAD^' 'HEAD' |\

Used long form attributes.

sed -n -E '/(before.*after.*ratio)|(BENCHMARKS)/,$p' >> out.txt
cat out.txt >> $GITHUB_STEP_SUMMARY
echo '```' >> $GITHUB_STEP_SUMMARY
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish-results.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
- uses: actions/setup-python@v4
uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.11'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python-version: '3.11'
python-version: '3.12'

See above.

- name: Install Requirements
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Install Requirements
- name: Install Requirements
run: python -m pip install --requirement requirements.txt

See above.
I wasn't able to select the line below in the suggestions, but you can delete it.

Expand Down
6 changes: 6 additions & 0 deletions environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
name: django-asv
dependencies:
- pip
- wheel
- conda-build
- libmambapy
Comment on lines +3 to +6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- pip
- wheel
- conda-build
- libmambapy
- conda-build
- libmambapy
- pip
- wheel

I only sorted dependencies, it can help in managing them.

2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
asv==0.6.3
asv==0.6.4
pre-commit