Skip to content

ws_protocol: Log when WebSocket is killed by Daphne #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ws_protocol: Log when WebSocket is killed by Daphne #474

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71dc15e
ws_protocol: Log when WebSocket is killed by Daphne
oliviermartin May 4, 2023
1a60647
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions daphne/ws_protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,11 +279,18 @@ def check_timeouts(self):
self.duration() > self.server.websocket_timeout
and self.server.websocket_timeout >= 0
):
logger.warning(
Copy link
Member

@carltongibson carltongibson May 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should probably use debug. (Both cases)

"WebSocket %s took too long and was killed.", self.client_addr
)
self.serverClose()
# Ping check
# If we're still connecting, deny the connection
if self.state == self.STATE_CONNECTING:
if self.duration() > self.server.websocket_connect_timeout:
logger.warning(
"WebSocket %s connection took too long and was killed.",
self.client_addr,
)
self.serverReject()
elif self.state == self.STATE_OPEN:
if (time.time() - self.last_ping) > self.server.ping_interval:
Expand Down