Renamed internal methods in core channel layer. #410
Conversation
|
Will add compatibility fallbacks in django/channels#2145 — we can resolve this more leisurely. |
|
@andrewgodwin @carltongibson what is the status of this, folks? can it be merged / released by chance? Can we make |
|
@shcheklein Channels has fallbacks here. Are you hitting an error? |
|
@carltongibson no, no errors. Tons of warnings on our CI. |
|
Ok, sure. So you can filter those in the short run. This PR needs a bit of work to be merged. We're currently testing all the way back to Channels 3 and various versions of the Redis python dependency. All of that would need removing from the tox and GHA configs. Etc. If you'd fancy picking that up it would be great. |
carltongibson
force-pushed
the
update-for-channels-4.2.1
branch
from
d5d994a to
00be12e
Compare
Internal API was renamed in Channels 4.2.1
carltongibson
force-pushed
the
update-for-channels-4.2.1
branch
from
00be12e to
be98e28
Compare
- Drop testing against Channels 3. - Test against latest Channels 4.x - Continue to test against Channels development branch.
carltongibson
force-pushed
the
update-for-channels-4.2.1
branch
from
fcdee96 to
df9b70e
Compare
- Update tested versions to 5, 6, and main. - Simplify matrix to focus outliers against known versions.
|
@shcheklein It turns out I got a moment. Here you go: https://pypi.org/project/channels-redis/4.3.0/ |
|
@carltongibson amazing, thank you!! |
Internal API was renamed in Channels 4.2.1
Initial rename will work for new versions, but not older channels versions. Maybe just need to make channels>=4.2.1. a requirement.