Sentinel authentication (sentinel_kwargs) #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriilahuta
force-pushed
the
sentinel-kwargs
branch
2 times, most recently
from
405eafd to
9fb92bc
Compare
andriilahuta
force-pushed
the
sentinel-kwargs
branch
from
9fb92bc to
3195822
Compare
|
Thanks for this @andriilahuta — I will review for the 4.0 release. (Just working on Channel ATM before cutting back here.) |
carltongibson
force-pushed
the
sentinel-kwargs
branch
from
3195822 to
0f3526c
Compare
carltongibson
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
OK, let's have it. Thanks @andriilahuta!
4.0 will be next week. 🤞
fredfsh
pushed a commit
to cobalt-robotics/channels_redis
that referenced
this pull request
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #300.