Invoice: add "credit note" type and add invoice cancellation admin action #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetrDlouhy
force-pushed
the
pr/invoice_credit_note
branch
4 times, most recently
from
981a42c to
70ca04f
Compare
PetrDlouhy
force-pushed
the
pr/invoice_credit_note
branch
from
70ca04f to
279ee2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to correctly cancel invoices - in accounting the invoices should not be cancelled, but a Credit note invoice should be created. This PR adds that type of invoice and a function that would make this new invoice to cancel one.
@Alir3z4 It is possible, that the "Invoice duplicate" was meant for this? I am a bit confused about that type and what it means.
I think i also should create Credit note by calling
cancel_invoice()inreturn_order(). But maybe it would not be correct think to do for all users?