Skip to content

Admin: Add fsm-log support #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

Admin: Add fsm-log support #51

merged 1 commit into from
Jun 16, 2025

Conversation

pfouque
Copy link
Member

@pfouque pfouque commented Jun 11, 2025

Complete the scope of #49 by adding fsm-log support

Comment on lines +18 to +25
try:
import django_fsm_log # noqa: F401
except ModuleNotFoundError:
FSM_LOG_ENABLED = False
else:
FSM_LOG_ENABLED = True

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small improvement to avoid TypeErrors when fsm-log is not installed at all

Copy link

codecov bot commented Jun 11, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
django_fsm/admin.py 78.57% 3 Missing ⚠️
Files with missing lines Coverage Δ
django_fsm/admin.py 94.56% <78.57%> (-2.91%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pfouque pfouque changed the title Make it compatible with fsm-log Admin: Add fsm-log support Jun 11, 2025
@pfouque pfouque force-pushed the feat/admin_fsm_log branch 3 times, most recently from 86316c0 to 929c936 Compare June 12, 2025 15:06
@pfouque pfouque force-pushed the feat/admin_fsm_log branch 3 times, most recently from 7efd1af to 9508263 Compare June 13, 2025 14:21
@pfouque pfouque force-pushed the feat/admin_fsm_log branch 3 times, most recently from 5148c76 to 46a9cba Compare June 13, 2025 16:03
@pfouque pfouque force-pushed the feat/admin_fsm_log branch from 46a9cba to adf5576 Compare June 13, 2025 16:11
@pfouque pfouque merged commit ade9568 into feat/admin Jun 16, 2025
8 of 9 checks passed
@pfouque pfouque deleted the feat/admin_fsm_log branch June 16, 2025 06:40
pfouque added a commit that referenced this pull request Jun 25, 2025
pfouque added a commit that referenced this pull request Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant