Skip to content

fix: Admin burger menu not keeping item id's #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix: Admin burger menu not keeping item id's #288

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75e4351
fix: Admin burger menu not keeping item id's
Aiky30 Jul 8, 2022
175abc6
Cleaned up
Aiky30 Jul 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions djangocms_versioning/static/djangocms_versioning/js/actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,17 @@
li_anchor.setAttribute('class', 'cms-actions-dropdown-menu-item-anchor');
li_anchor.setAttribute('href', $(item).attr('href'));

// Copy the id attribute if it is set
const itemId = $(item).attr('id');
if (itemId !== undefined) {
li_anchor.setAttribute('id', itemId);
}
// Copy the target attribute if it is set
const itemTarget = $(item).attr('target');
if (itemTarget !== undefined) {
li_anchor.setAttribute('target', itemTarget);
}

if ($(item).hasClass('cms-form-get-method')) {
li_anchor.classList.add('cms-form-get-method'); // Ensure the fake-form selector is propagated to the new anchor
}
Expand Down