Skip to content

Conversation

marksweb
Copy link
Member

This adds an action button on the published content to take you to the content users will see via get_absolute_url.

How it looks with page content;
Screenshot 2022-04-13 at 20 46 52

How it looks with Alias where get_absolute_url returns the preview URL;
Screenshot 2022-04-14 at 17 11 21

@marksweb marksweb requested a review from Aiky30 April 14, 2022 22:26
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #272 (2d6dfc8) into master (31f14df) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #272   +/-   ##
=======================================
  Coverage   86.60%   86.60%           
=======================================
  Files          23       23           
  Lines         799      799           
  Branches      105      105           
=======================================
  Hits          692      692           
  Misses         81       81           
  Partials       26       26           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@Aiky30 Aiky30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch needs to be brought up to date.

Review contains a question and raises an issue with a duplicated template

@@ -8,10 +8,8 @@ skip_missing_interpreters=True

[testenv]
deps =
-r{toxinidir}/tests/requirements/requirements_base.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this because I thought that the isort and flake8 deps needed it, obviously not so no issues removing this.

Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @marksweb ! I am not sure if all versionable objects need to have a get_absolute_url method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review required
Development

Successfully merging this pull request may close these issues.

3 participants