discourse-doctor: prevent others from reading sensitive log content #987
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewschleifer
requested changes
Aug 22, 2025
discourse-doctor
Outdated
| @@ -348,6 +350,8 @@ print_done() { | |||
| initialize_log_file() { | |||
| rm -f $LOG_FILE | |||
| touch $LOG_FILE | |||
| # prevent others from reading sensitive content from the log | |||
| chmod 0600 $LOG_FILE | |||
There was a problem hiding this comment.
Instead of touch + chmod we should do it in a single command with install -m 0600 /dev/null $LOG_FILE. Then you can remove the comment.
There was a problem hiding this comment.
Makes sense. Change applied and rebase.
The log file is world-readable until the script finished, while sensitive settings are written to it at the very start. If the container is not running, a rebuild is done, which can leave the file with sensitive content world-readable for quite a long time. This commit makes the log file readable to root only, while the script is running, and applies default mode only after sensitive content has been reducted, for convenience and to remain a non-breaking change. An alternative would be to redact sensitive content right after it was written, in the `get_discourse_config()` function, but it would require more code and sensitive content might be printed later as well if a rebuild is done. Signed-off-by: MichaIng <[email protected]>
MichaIng
force-pushed
the
harden-doctor-log-mode
branch
from
e217d97 to
f8e35af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log file is world-readable until the script finished, while sensitive settings are written to it at the very start. If the container is not running, a rebuild is done, which can leave the file with sensitive content world-readable for quite a long time.
This commit makes the log file readable to root only, while the script is running, and applies default mode only after sensitive content has been reducted, for convenience and to remain a non-breaking change.
An alternative would be to redact sensitive content right after it was written, in the
get_discourse_config()function, but it would require more code and sensitive content might be printed later as well if a rebuild is done.