FIX: Use bundle config instead of flags removed in Bundler 4.x (phpbb3 import)#1075
Open
thomasrossetto wants to merge 1 commit into
Open
FIX: Use bundle config instead of flags removed in Bundler 4.x (phpbb3 import)#1075thomasrossetto wants to merge 1 commit into
thomasrossetto wants to merge 1 commit into
Conversation
…3 import) Bundler 4.x removed the --path, --no-deployment and --without install flags because they relied on being persisted across invocations. With the Bundler version shipped in the base image (4.0.14) the phpbb3 import hook fails (e.g. "The --path flag has been removed ...") and the import container bootstrap aborts with exit 15. Move those settings to explicit 'bundle config set --local' calls and drop the removed flags from 'bundle install', as the Bundler error message itself suggests.
|
Need to merge this - i've spent a few hours cause of this old commands, gpt gave same solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The phpbb3 import template's
after_bundle_exechook calls:Bundler 4.x has removed the
--path,--no-deploymentand--withoutinstall flags because they relied on being persisted across invocations. With the Bundler version now shipped in the base image (4.0.14), the hook fails with e.g.The --path flag has been removed ...and the import container bootstrap aborts (exit 15).This moves those settings to explicit
bundle config set --local ...calls and drops the removed flags frombundle install, which is the migration path Bundler itself suggests in the error message.Note: the same pattern exists in the
mssql-dep,mysql-dep,vanillaandmboximport templates. This PR is scoped tophpbb3; happy to extend it to the others if preferred.