Skip to content

DEV: Remove the legacy widget code #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

DEV: Remove the legacy widget code #135

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94f2456
DEV: Remove deprecated widget overrides and streamline `post` handling
megothss Sep 19, 2025
061c34f
DEV: Clean up unused `PLUGIN_ID` in `whos-online` initializer
megothss Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 0 additions & 60 deletions assets/javascripts/discourse/api-initializers/intitialize-whos-online-indicators.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
import bodyClass from "discourse/helpers/body-class";
import { apiInitializer } from "discourse/lib/api";
import { withSilencedDeprecations } from "discourse/lib/deprecated";

const PLUGIN_ID = "whos-online";

export default apiInitializer((api) => {
const siteSettings = api.container.lookup("service:site-settings");
Expand Down Expand Up @@ -93,61 +90,4 @@ function customizePost(api) {
return value;
}
);

withSilencedDeprecations("discourse.post-stream-widget-overrides", () =>
customizeWidgetPost(api)
);
}

function customizeWidgetPost(api) {
api.modifyClass("component:scrolling-post-stream", {
pluginId: PLUGIN_ID,

didInsertElement() {
this._super();
this.appEvents.on("whosonline:changed", this, this._whosOnlineCallback);
},

willDestroyElement() {
this.appEvents.off("whosonline:changed", this, this._whosOnlineCallback);
},

_whosOnlineCallback(changedUserIds) {
changedUserIds.forEach((id) => {
let postIds = this.attrs.posts.value
.filter(({ user_id }) => {
return user_id === id;
})
.map((post) => post.id);
postIds.forEach((postId) => {
this.dirtyKeys.keyDirty(`post-${postId}`);
this.dirtyKeys.keyDirty(`post-${postId}-avatar-${id}`, {
onRefresh: "updateOnline",
});
});
});
this.queueRerender();
},
});

api.reopenWidget("post-avatar", {
buildKey: (attrs) => `post-${attrs.id}-avatar-${attrs.user_id}`,
isUserOnline(userId) {
return this.register.lookup("service:whos-online").isUserOnline(userId);
},
defaultState(attrs) {
return {
online: this.isUserOnline(attrs.user_id),
};
},
updateOnline() {
this.state.online = this.isUserOnline(this.attrs.user_id);
},
buildClasses(attrs, state) {
if (state.online) {
return "user-online";
}
return [];
},
});
}