Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: update emoji, better icon match #122

Merged
merged 1 commit into from
Mar 21, 2025
Merged

UX: update emoji, better icon match #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...s/discourse-user-notes/connectors/after-reviewable-post-user/show-user-notes-on-flags.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
<img
src={{this.emojiUrl}}
title={{this.userNotesTitle}}
alt="pencil"
alt=""
class="emoji"
/>
{{else}}
{{d-icon "note-sticky"}}
{{d-icon "pen-to-square"}}
{{/if}}
</DButton>
{{/if}}
2 changes: 1 addition & 1 deletion ...ts/discourse-user-notes/connectors/after-reviewable-post-user/show-user-notes-on-flags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default {
component.setProperties({
userNotesCount,
emojiEnabled: component.siteSettings.enable_emoji,
emojiUrl: emojiUrlFor("pencil"),
emojiUrl: emojiUrlFor("memo"),
userNotesTitle: i18n("user_notes.show", { count: userNotesCount }),
});
},
Expand Down
4 changes: 2 additions & 2 deletions ...ascripts/discourse-user-notes/connectors/user-card-post-names/show-user-notes-on-card.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ export default class extends Component {
class="btn-flat"
>
{{#if this.siteSettings.enable_emoji}}
{{emoji "pencil"}}
{{emoji "memo"}}
{{else}}
{{icon "note-sticky"}}
{{icon "pen-to-square"}}
{{/if}}
</DButton>
{{/if}}
Expand Down
2 changes: 1 addition & 1 deletion assets/javascripts/discourse/components/show-user-notes.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<DButton
class="btn-default show-user-notes-btn"
@action={{@show}}
@icon="pencil"
@icon="pen-to-square"
@translatedLabel={{this.label}}
/>
6 changes: 3 additions & 3 deletions assets/javascripts/discourse/initializers/enable-user-notes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export default {
});
api.addPostAdminMenuButton((attrs) => {
return {
icon: "pencil",
icon: "pen-to-square",
label: "user_notes.attach",
action: (post) => {
showUserNotes(
Expand Down Expand Up @@ -103,9 +103,9 @@ export default {

html() {
if (this.siteSettings.enable_emoji) {
return this.attach("emoji", { name: "pencil" });
return this.attach("emoji", { name: "memo" });
} else {
return iconNode("note-sticky");
return iconNode("pen-to-square");
}
},
});
Expand Down
2 changes: 1 addition & 1 deletion plugin.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

register_asset "stylesheets/user_notes.scss"

register_svg_icon "note-sticky"
register_svg_icon "pen-to-square"

after_initialize do
require_dependency "user"
Expand Down