FIX: Accepting another answer does not commit #360
Merged
+92
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyb-talks
approved these changes
Apr 4, 2025
| unless acting_user.id == post.user_id | ||
| Notification.create!( | ||
| notification_type: Notification.types[:custom], | ||
| user_id: post.user_id, |
There was a problem hiding this comment.
I wonder if we should make it more obvious the only difference between these 2 Notification.create calls is the user_id? Could be a signal to DRY these other attributes out to a common variable as well.
There was a problem hiding this comment.
Possibly, but the notification should only be created in the case of the conditions above, I suspect which is why the original author didn't try to optimise further as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an answer already exists, clicking "✅ Solution" on another post works, but does not commit.
This PR fixes that and also adds a test, and a transaction around accepting a solution (deleting the topic timer, previous user action, etc).