FIX: Ensure dates passed in query params are parsed in the local timezone. #365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What's This?
When passing date values for reports as URL parameters, they were being parsed by the standard JavaScript
Date
object, which due to legacy reasons parses date-only strings in UTC, all other date formats are assumed to be in the browser's local timezone.This change switches to using
moment
's parser, which assumes that all strings passed to it are in the browser's local timezone.👑 Testing