FIX: Query downloads were being passed an incorrect query object. #359
+84
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| await click("form.query-run button"); | ||
|
|
||
| const createElement = document.createElement.bind(document); |
There was a problem hiding this comment.
Personally I would have written this as a system spec to avoid needing to do all these mocks and stubs, but it's cool you got it to work this way 👍
martin-brennan
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What's This?
This is a follow-up to #356.
The previous PR missed changing the name of the query object when passing it to
QueryResultsWrapper, which resulted in the download links not working properly after a query was run.This change fixes that bug, and includes an acceptance test to ensure it stays fixed during future work on this plugin.
👑 Testing
/admin/plugins/explorer