FEATURE: Configure persona backed features in admin panel #1245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keegangeorge
commented
Apr 4, 2025
Comment on lines
-108
to
-111
| include_condition: -> do | ||
| SiteSetting.ai_bot_enabled && scope.authenticated? && | ||
| scope.user.in_any_groups?(SiteSetting.ai_bot_allowed_groups_map) | ||
| end, |
There was a problem hiding this comment.
I am removing the dependency for SiteSetting.ai_bot_enabled to add ai_enabled_personas to current user serializer. Since we want features to be backed by personas, I don't think it should be dependant on AI bot anymore.
Also, discobot discoveries uses ai_bot_enabled for it's enabling setting, so if we disable discoveries in the feature list, then the dropdown to show personas will no longer work.
There was a problem hiding this comment.
Copilot reviewed 16 out of 20 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- admin/assets/javascripts/discourse/templates/admin-plugins/show/discourse-ai-features/edit.gjs: Language not supported
- admin/assets/javascripts/discourse/templates/admin-plugins/show/discourse-ai-features/index.gjs: Language not supported
- assets/javascripts/discourse/components/ai-feature-editor.gjs: Language not supported
- assets/stylesheets/common/ai-features.scss: Language not supported
keegangeorge
commented
Apr 4, 2025
…ture (#1248) This update makes use of the `area` key in `settings.yml` to show all settings related to particular features inside their feature tab editor. This allows admins to easily configure features and parse through a variety of different settings.
There was a problem hiding this comment.
Copilot reviewed 21 out of 24 changed files in this pull request and generated no comments.
Files not reviewed (3)
- admin/assets/javascripts/discourse/templates/admin-plugins/show/discourse-ai-features/edit.gjs: Language not supported
- admin/assets/javascripts/discourse/templates/admin-plugins/show/discourse-ai-features/index.gjs: Language not supported
- assets/stylesheets/common/ai-features.scss: Language not supported
Comments suppressed due to low confidence (1)
lib/ai_bot/entry_point.rb:108
- The updated inclusion condition for the current user serializer removes the checks for 'ai_bot_enabled' and group membership, which might alter the intended access control behavior. Please confirm that this change is intentional.
include_condition: -> { scope.authenticated? },
xfalcox
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Overview
In this feature update, we add the UI for the ability to easily configure persona backed AI-features. The feature will still be hidden until structured responses are complete.
📸 Screenshots