fix: memory leak in event triggers (#1075)

discordx-ts · Nov 3, 2024 · 4bf6131 · 4bf6131
1 parent 82612ac
commit 4bf6131
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/packages/discordx/CHANGELOG.md b/packages/discordx/CHANGELOG.md
@@ -1,5 +1,11 @@
 # discordx
 
+## 11.12.2
+
+### Patch Changes
+
+- fix memory leak in event triggers
+
 ## 11.12.1
 
 ### Patch Changes

diff --git a/packages/discordx/package.json b/packages/discordx/package.json
@@ -1,6 +1,6 @@
 {
   "name": "discordx",
-  "version": "11.12.1",
+  "version": "11.12.2",
   "private": false,
   "description": "Create a discord bot with TypeScript and Decorators!",
   "keywords": [

diff --git a/packages/discordx/src/logic/metadata/MetadataStorage.ts b/packages/discordx/src/logic/metadata/MetadataStorage.ts
@@ -588,8 +588,6 @@ export class MetadataStorage {
    * @param options - Even data
    */
   trigger(options: ITriggerEventData): (...params: any[]) => any {
-    const responses: any[] = [];
-
     const eventsToExecute = this._events.filter((on) => {
       return (
         on.event === options.event &&
@@ -599,6 +597,7 @@ export class MetadataStorage {
     });
 
     return async (...params: any[]) => {
+      const responses: any[] = [];
       await Promise.all(
         eventsToExecute.map(async (ev) => {
           if (!ev.isBotAllowed(options.client.botId)) {