Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Massive refactoring #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Massive refactoring #2

wants to merge 2 commits into from

Conversation

In-line
Copy link

@In-line In-line commented May 18, 2019

No description provided.

@In-line
Copy link
Author

In-line commented May 18, 2019

I'm running benchmarks to see if there is negative impact somewhere.

@In-line
Copy link
Author

In-line commented May 18, 2019

After refactoring.

Operating System: Linux"
CPU Information: Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz
Number of Available Cores: 4
Available memory: 15.54 GB
Elixir 1.8.1
Erlang 21.3.2


##### With input 0005-1.    5000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.94 K      339.67 μs    ±16.62%         327 μs         532 μs

##### With input 0005-2.    5000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.81 K      355.27 μs    ±20.90%         339 μs      586.52 μs

##### With input 0005-3.    5000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        3.84 K      260.24 μs    ±24.69%         245 μs         432 μs

##### With input 0050-1.   50000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.71 K      369.06 μs    ±19.13%         359 μs      562.42 μs

##### With input 0050-2.   50000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.67 K      375.03 μs    ±15.85%         357 μs         619 μs

##### With input 0050-3.   50000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.87 K      347.88 μs    ±60.37%         334 μs      500.28 μs

##### With input 0250-1.  250000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.57 K      388.76 μs    ±14.47%         371 μs      640.60 μs

##### With input 0250-2.  250000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        1.87 K      534.73 μs    ±14.68%         513 μs      806.64 μs

##### With input 0250-3.  250000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        1.62 K      618.03 μs    ±15.68%         580 μs     1010.59 μs

##### With input 0500-1.  500000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.78 K      359.56 μs     ±6.54%         351 μs      464.84 μs

##### With input 0500-2.  500000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        1.55 K      643.14 μs     ±4.44%         632 μs      762.02 μs

##### With input 0500-3.  500000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        1.16 K      859.11 μs     ±3.53%         843 μs      991.20 μs

##### With input 0750-1.  750000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.74 K      364.81 μs     ±5.41%         358 μs      463.92 μs

##### With input 0750-2.  750000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        1.25 K      799.96 μs     ±3.42%         790 μs      920.02 μs

##### With input 0750-3.  750000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        870.31        1.15 ms     ±5.68%        1.12 ms        1.41 ms

##### With input 1000-1. 1000000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.70 K      370.01 μs     ±7.22%         360 μs      510.32 μs

##### With input 1000-2. 1000000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        1.01 K      990.45 μs    ±11.34%         948 μs     1450.84 μs

##### With input 1000-3. 1000000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        639.76        1.56 ms    ±18.22%        1.46 ms        3.00 ms

@In-line
Copy link
Author

In-line commented May 18, 2019

Master

##### With input 0005-1.    5000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.91 K      343.58 μs    ±18.85%         326 μs         566 μs

##### With input 0005-2.    5000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.99 K      334.84 μs    ±12.55%         323 μs         502 μs

##### With input 0005-3.    5000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        3.89 K      257.08 μs    ±27.78%         246 μs      401.71 μs

##### With input 0050-1.   50000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.78 K      359.72 μs    ±20.09%         342 μs         560 μs

##### With input 0050-2.   50000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.68 K      373.58 μs    ±18.21%         358 μs      574.46 μs

##### With input 0050-3.   50000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.87 K      348.96 μs    ±15.05%         332 μs      542.70 μs

##### With input 0250-1.  250000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.68 K      372.90 μs    ±11.83%         360 μs      579.60 μs

##### With input 0250-2.  250000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        1.81 K      551.04 μs    ±16.04%         528 μs         867 μs

##### With input 0250-3.  250000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        1.61 K      621.36 μs    ±19.49%         592 μs      963.34 μs

##### With input 0500-1.  500000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.63 K      380.90 μs    ±12.17%      366.50 μs      566.42 μs

##### With input 0500-2.  500000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        1.53 K      651.81 μs     ±9.70%         628 μs      908.06 μs

##### With input 0500-3.  500000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        1.19 K      840.02 μs     ±4.58%         825 μs      964.90 μs

##### With input 0750-1.  750000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.81 K      356.40 μs     ±4.61%         352 μs      424.99 μs

##### With input 0750-2.  750000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        1.25 K      798.20 μs     ±9.01%         784 μs         893 μs

##### With input 0750-3.  750000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        892.89        1.12 ms     ±3.70%        1.10 ms        1.34 ms

##### With input 1000-1. 1000000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.82 K      355.03 μs     ±4.05%         351 μs      432.24 μs

##### With input 1000-2. 1000000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        1.05 K      950.92 μs     ±2.09%         946 μs     1038.49 μs

##### With input 1000-3. 1000000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        731.29        1.37 ms     ±2.79%        1.35 ms        1.52 ms

@In-line
Copy link
Author

In-line commented May 18, 2019 •
edited
Loading

LTO + master

##### With input 0005-1.    5000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        3.27 K      305.82 μs    ±27.66%         291 μs         500 μs

##### With input 0005-2.    5000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        3.33 K      300.50 μs    ±27.30%         287 μs         461 μs

##### With input 0005-3.    5000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        4.39 K      227.74 μs    ±21.49%         217 μs      389.51 μs

##### With input 0050-1.   50000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        3.04 K      328.42 μs    ±13.66%         315 μs      490.60 μs

##### With input 0050-2.   50000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        3.04 K      329.17 μs    ±10.52%         319 μs         490 μs

##### With input 0050-3.   50000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        3.31 K      302.14 μs     ±8.70%         297 μs         429 μs

##### With input 0250-1.  250000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        3.03 K      329.67 μs     ±7.89%         324 μs      448.46 μs

##### With input 0250-2.  250000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.07 K      482.99 μs    ±10.29%         474 μs      657.80 μs

##### With input 0250-3.  250000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        1.81 K      551.14 μs     ±8.64%         544 μs      759.60 μs

##### With input 0500-1.  500000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.97 K      336.71 μs     ±6.30%         334 μs      426.17 μs

##### With input 0500-2.  500000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        1.57 K      635.48 μs     ±8.77%         624 μs      889.76 μs

##### With input 0500-3.  500000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        1.23 K      815.58 μs     ±5.82%         797 μs     1032.90 μs

##### With input 0750-1.  750000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.84 K      352.57 μs    ±12.34%         338 μs      517.36 μs

##### With input 0750-2.  750000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        1.15 K      865.91 μs    ±14.88%         827 μs     1455.20 μs

##### With input 0750-3.  750000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        847.09        1.18 ms    ±12.75%        1.13 ms        1.76 ms

##### With input 1000-1. 1000000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.67 K      374.67 μs    ±32.50%      342.50 μs      966.03 μs

##### With input 1000-2. 1000000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        1.02 K      983.91 μs    ±10.62%         942 μs     1398.80 μs

##### With input 1000-3. 1000000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        679.99        1.47 ms    ±15.50%        1.39 ms        2.30 ms

@In-line
Copy link
Author

In-line commented May 18, 2019

LTO + refactored

##### With input 0005-1.    5000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        3.32 K      301.26 μs    ±15.68%         292 μs      459.58 μs

##### With input 0005-2.    5000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.89 K      346.39 μs    ±40.89%         303 μs         731 μs

##### With input 0005-3.    5000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        3.76 K      265.66 μs    ±47.91%         195 μs         580 μs

##### With input 0050-1.   50000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.54 K      393.03 μs    ±46.73%         295 μs         898 μs

##### With input 0050-2.   50000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        3.03 K      330.10 μs    ±11.58%         319 μs      481.28 μs

##### With input 0050-3.   50000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        3.45 K      290.21 μs    ±12.17%         280 μs      426.70 μs

##### With input 0250-1.  250000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        3.03 K      330.25 μs    ±12.77%         321 μs      454.20 μs

##### With input 0250-2.  250000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        1.97 K      507.18 μs    ±11.89%         493 μs      765.08 μs

##### With input 0250-3.  250000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        1.78 K      560.33 μs     ±9.57%         546 μs      776.19 μs

##### With input 0500-1.  500000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        3.11 K      321.89 μs     ±7.59%         315 μs      425.78 μs

##### With input 0500-2.  500000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        1.37 K      727.80 μs    ±34.07%         673 μs     1577.04 μs

##### With input 0500-3.  500000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        1.15 K      868.75 μs     ±5.92%         856 μs     1072.18 μs

##### With input 0750-1.  750000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.94 K      340.47 μs     ±9.70%         333 μs      495.26 μs

##### With input 0750-2.  750000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        959.88        1.04 ms    ±32.81%        0.94 ms        2.69 ms

##### With input 0750-3.  750000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        721.38        1.39 ms    ±20.23%        1.29 ms        2.65 ms

##### With input 1000-1. 1000000 Set // 500 cell // Beginning #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        2.63 K      380.13 μs    ±48.56%         360 μs      692.82 μs

##### With input 1000-2. 1000000 Set // 500 cell // Middle #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        842.74        1.19 ms    ±12.73%        1.15 ms        1.95 ms

##### With input 1000-3. 1000000 Set // 500 cell // Ending #####
Name                         ips        average  deviation         median         99th %
Add 1000 New Items        576.58        1.73 ms    ±11.17%        1.68 ms        2.71 ms

@In-line
Copy link
Author

In-line commented May 18, 2019

Results for me are inconsistent. I used my laptop while benchmarking (it is just to long), so It will be better to benchmark more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@In-line