Skip to content

Conversation

onerandomusername
Copy link
Contributor

These parameters are not all nullable.

@onerandomusername onerandomusername requested a review from a team as a code owner September 22, 2025 16:49
@onerandomusername onerandomusername requested review from anthonydiscord and removed request for a team September 22, 2025 16:49
@onerandomusername onerandomusername changed the title Update message.mdx to remove optional parameters info Update Edit Message to reflect that not every parameter is nullable Sep 22, 2025
@Jiralite
Copy link
Contributor

This is a breaking change, no? What happened?

@vladfrangu
Copy link
Contributor

Is this PR supposed to remove just the nullable callout from the admonition? Because making PATCH not have optional fields is a super breaking change, and I hope that didn't happen

@advaith1
Copy link
Contributor

All patch params are optional and always will be optional.

@onerandomusername onerandomusername force-pushed the patch-2 branch 2 times, most recently from 94763b2 to dd41fe2 Compare September 23, 2025 05:21
@onerandomusername
Copy link
Contributor Author

Apologies, deleted a bit too much. Edited this to be in alignment with what seems to be the actual API behaviour, and with what DV8 committed earlier.

@anthonydiscord
Copy link
Contributor

I was playing around with this and poll, attachments, embeds, and flags can all be null (as long as their is some valid content for the message). Likely some of the others can be as well? Am I missing something or are there any that can't be null? I do think it makes sense to add * for all nullable options even though we call it out above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants