Skip to content

Updated alert boxes #7484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 21, 2025
Merged

Updated alert boxes #7484

merged 4 commits into from
Apr 21, 2025

Conversation

GeniusTimo
Copy link
Contributor

In order to resolve my review comments from #7482, I solved them myself within this pull request. As I mentioned over there the contributing guidelines are now outdated, so this is still pending and resolved by this pull request as I'm not sure about the wording in English for :::

This explanation is also worth updating to avoid confusion

Originally posted by @GeniusTimo in #7482 (comment)

Also just as a note, I split MacOS and Windows into separate lines now as proposed

Not 100 % sure about this one. This is what it looks like before this pull request:
image

Originally posted by @GeniusTimo in #7482 (comment)

CC @JustinBeckwith

@GeniusTimo GeniusTimo requested a review from a team as a code owner April 21, 2025 18:20
@GeniusTimo GeniusTimo requested review from JustinBeckwith and removed request for a team April 21, 2025 18:20
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@JustinBeckwith JustinBeckwith merged commit 57900b3 into discord:main Apr 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants