Fix unintended double triggering of key bindings during IME composition#339
Merged
pacocoursey merged 3 commits intodip:mainfrom Mar 14, 2025
Merged
Fix unintended double triggering of key bindings during IME composition#339pacocoursey merged 3 commits intodip:mainfrom
pacocoursey merged 3 commits intodip:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I really want this PR to be applied. 😀 I think we can use the following methods temporarily. <Command
...
onKeyDown={(e) => {
if (e.nativeEvent.isComposing) e.preventDefault();
}} /> |
pacocoursey
reviewed
Mar 14, 2025
pacocoursey
approved these changes
Mar 14, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses a bug where key bindings were unintentionally triggered twice during IME (Input Method Editor) composition. The issue occurred because IME input events were not properly handled, leading to duplicate keybinding activations in certain scenarios.
Problem:
When using an IME for text input (e.g., for languages like Korean, Japanese, or Chinese), the composition process generates intermediate key events. In the current implementation, these events were mistakenly causing the key binding logic to execute twice—once for the actual input and once for the intermediate composition event.