You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@pacocoursey this improvement is important in order to allow setting aria attributes that need to be set (or override) to be WCAG compliant. Do you think this PR can be accepted and merged in the next few weeks?
At the time of this comment 3 out of 9 open PRs are about overriding components props. So I think it's indeed a need the community has. @pacocoursey please approve 1 of the PRs, or provide us the reason why you don't.
It would also help overriding the autoComplete prop on the input, which is set to off right now.
Some browsers (including chrome) ignore this prop when set to off, resulting in the browser native panel showing above the command list. Setting this prop to a custom value can prevent this behavior.
@pacocoursey Are you still maintaining this project?
If you don't have the capacity to do so, may I ask you to try and find another maintainer?
Maybe we can find a volunteer to help you out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improvement is important in order to allow setting aria attributes that need to be set (or override) to be WCAG compliant.