Skip to content

Fix duplicate key issue in getOwnerPetsMap-created-by-agentic #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix duplicate key issue in getOwnerPetsMap-created-by-agentic #90

wants to merge 1 commit into from

Conversation

@shaykeren
Copy link

This PR fixes an IllegalStateException occurring in the GET /owners/pets endpoint due to duplicate keys when mapping pets to owners.

Changes made:

  1. Modified getOwnerPetsMap method to use Collectors.groupingBy instead of Collectors.toMap
  2. Added proper handling of multiple pets per owner
  3. Improved error handling for null cases
  4. Added logging for better monitoring

This fixes the issue where multiple pets belonging to the same owner would cause an IllegalStateException.

@shaykeren shaykeren mentioned this pull request Jul 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shaykeren