Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration path Env Var. #2015

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Conversation

Montmorency
Copy link
Contributor

Adds an environment variable so user can run migration systemd service from any directory on FileSystem. Useful in certain production situations. Defaults to the previous value. Docs updated.

@amitaibu
Copy link
Collaborator

Useful in certain production situations.

I'm curious, what's your use case?

Copy link
Member

@mpscholten mpscholten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@mpscholten
Copy link
Member

With this we can now simplify the migration service here https://github.com/digitallyinduced/ihp/blob/master/NixSupport/nixosModules/services/migrate.nix#L10 a little bit

@mpscholten mpscholten merged commit f59b36f into digitallyinduced:master Nov 19, 2024
2 checks passed
@Montmorency
Copy link
Contributor Author

With this we can now simplify the migration service here https://github.com/digitallyinduced/ihp/blob/master/NixSupport/nixosModules/services/migrate.nix#L10 a little bit

Yes that line confuses me 😄 . What can it be switched to now?

@mpscholten
Copy link
Member

simplified version is here https://github.com/digitallyinduced/ihp/pull/2016/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants