Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a more robust check for isUrl validator #1880

Merged
merged 2 commits into from
Dec 30, 2023
Merged

Use a more robust check for isUrl validator #1880

merged 2 commits into from
Dec 30, 2023

Conversation

amitaibu
Copy link
Collaborator

image

@amitaibu amitaibu requested a review from mpscholten December 29, 2023 19:42
mpscholten
mpscholten approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@mpscholten mpscholten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 Thanks!

@mpscholten mpscholten merged commit 9fe2cde into master Dec 30, 2023
2 checks passed
@mpscholten mpscholten deleted the isUrl-fix branch December 30, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpscholten mpscholten mpscholten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amitaibu @mpscholten