Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable pylint rules 1 #501

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Enable pylint rules 1 #501

merged 1 commit into from
Oct 23, 2023

Conversation

MizukiTemma
Copy link
Member

@MizukiTemma MizukiTemma commented Oct 6, 2023 •
edited
Loading

Short description

This PR enables pylint rules which are currently disabled.

Proposed changes

  • Enable raise-missiong-from
  • Enable empty-docstring
  • Enable missing-function-docsring
  • Enable property-with-parameters

Resolved issues

Fixes: (#499, partially)

@MizukiTemma
Copy link
Member Author

We can probably leave missing-module-docstring, invalid-name, no-member and line-too-long disabled as they are in Integreat CMS, to which our members are used to.

@MizukiTemma MizukiTemma changed the title [In Progress] Enable pylint rules [In Progress] Enable pylint rules 1 Oct 20, 2023
@MizukiTemma MizukiTemma changed the title [In Progress] Enable pylint rules 1 Enable pylint rules 1 Oct 20, 2023
@MizukiTemma MizukiTemma marked this pull request as ready for review October 20, 2023 13:45
@MizukiTemma MizukiTemma requested a review from a team as a code owner October 20, 2023 13:45
@MizukiTemma
Copy link
Member Author

Other rules seem to bring a lot of changes, so I'll open this PR once.

timobrembeck
timobrembeck requested changes Oct 20, 2023
View reviewed changes
Copy link
Member

@timobrembeck timobrembeck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍
I think just the module paths need to be adapted to enable Sphinx to link them correctly.

@MizukiTemma
Copy link
Member Author

@timobrembeck Thank you for the review 🙂 I applied the same changes to other similar lines too.

timobrembeck
timobrembeck approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@timobrembeck timobrembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍
After squashing the commits, this is good to go! 🚀

@MizukiTemma @timobrembeck
Apply pylint rules
e4ef416 
Co-authored-by: Timo Brembeck <[email protected]>
@MizukiTemma MizukiTemma merged commit 6ce05a4 into develop Oct 23, 2023
@MizukiTemma MizukiTemma deleted the pylint_rules branch October 23, 2023 13:54
@MizukiTemma MizukiTemma mentioned this pull request Oct 23, 2023
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timobrembeck timobrembeck timobrembeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MizukiTemma @timobrembeck