Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only users with publishing rights can archive pages #3457

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

only users with publishing rights can archive pages #3457

wants to merge 1 commit into from

Conversation

jonbulz
Copy link
Contributor

@jonbulz jonbulz commented Feb 20, 2025

Short description

Only users with publishing rights should be able to archive pages

Proposed changes

  • change necessary permissions for archiving from "cms.change_page_object" to "cms.publish_page_object"
  • don't show archive button to users without publishing rights

Side effects

  • some users without publishing rights might be used to archiving pages and could be confused

Resolved issues

Fixes: #3374

Pull Request Review Guidelines

@jonbulz jonbulz force-pushed the enhancement/archive_pages_only_with_publish_rights branch from 9c8f1cb to 6ac7ee3 Compare February 22, 2025 13:07
JoeyStk
JoeyStk approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeyStk JoeyStk JoeyStk approved these changes

@charludo charludo Awaiting requested review from charludo

@juliankehne juliankehne Awaiting requested review from juliankehne

@MizukiTemma MizukiTemma Awaiting requested review from MizukiTemma

@jarlhengstmengel jarlhengstmengel Awaiting requested review from jarlhengstmengel

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The user role "Author" should not be allowed to archive pages
2 participants
@jonbulz @JoeyStk