Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing of start and end date in event #3439

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

JoeyStk
Copy link
Contributor

@JoeyStk JoeyStk commented Feb 17, 2025

Short description

This PR fixes the spacing in the start and end date in events as they are currently being cut off. The first idea to change the width of the sidebars wasn't as easy as thought as it came with a bunch of side effects. Therefore I stuck to the second idea and put the two input fields below each other. If you have other ideas for this fix, please let me know :)

Proposed changes

  • Put start and end date beneath each other instead of next to each other

Side effects

  • There might be, but I don't know about them at the moment

Resolved issues

Fixes: #3424


Pull Request Review Guidelines

Copy link
Contributor

@charludo charludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The start field taking full width whenever no end field is present also looks nicer than before imo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The year of Start & end date of an event is cut off
2 participants