Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix live content in page preview #3427

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MizukiTemma
Copy link
Member

Short description

This PR fixes rendering of live content in the page preview

Proposed changes

  • Fix the region slug of the mirrored pages

Side effects

  • I hope none 🙈
  • The page preview functionality is available both on the page tree (👁️ icon) and on the page form. Please check both are working fine and in the same way
  • Please check also, that the styling is fine (see Fix styling of page preview #3396 )
  • Please check also (sorry for such many "please"s), that the rendering is working fine after changing the embedded content before and after saving the form.

Resolved issues

Fixes: #3426


Pull Request Review Guidelines

Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! This fixes the issue for me!

During testing I noticed the following formatting of the page:

Element Is it shown correctly?
Marking text as bold Yes
Marking text as italic Yes
Marking text as underlined Yes
Marking text as crossed out Yes
Marking text as lowered Yes
Marking text as superscript Yes
Marking text in a color Yes
Marking text with a background color Yes
Headline 2 No
Headline 3 No
Unordered list Yes
Ordered list No
Text aligned to the left Yes
Text aligned to the right Yes
Text aligned to the center Yes
Text aligned fully formatted Yes
Inserted image Yes
Inserted link Yes
Inserted contact Yes
Inserted special character Yes
Inserted icon Yes

Besides the ordered list and the headlines every seems to be formatted correctly! :)

@JoeyStk JoeyStk mentioned this pull request Feb 17, 2025
Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the mentioned issue will be fixed in #3433, I'll approve this PR 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Live Content shows up as "undefined" in the page preview
2 participants