Move automatically saved note #3415
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeyStk
requested review from
PeterNerlich,
charludo,
MizukiTemma,
jonbulz and
jarlhengstmengel
MizukiTemma
approved these changes
Feb 11, 2025
Thank you very much! Could you please give me an example where we might run into a problem with the current implementation. I'm not doubting your suggestions, I'm just wondering :) |
JoeyStk
force-pushed
the
enhancement/move-automatically-saved-note
branch
from
c18aa1e to
d299824
Compare
|
@MizukiTemma thank you for your suggestions! For the other ones: This PR is ready to be reviewed again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Since adding the "Cancel" button on content forms, the info message that the page/event/poi has been automatically saved is in between two buttons, which doesn't look great. This PR moves the note so that it shows to the far left again.
Proposed changes
Side effects
Resolved issues
Fixes: #3327
Pull Request Review Guidelines