-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust filters for long term events #3410
base: develop
Are you sure you want to change the base?
Conversation
If some knows how to fix the tests, I'm open to suggestions! @jonbulz Mizuki gave me the hint that you might something about this :) |
@JoeyStk alright seems that renaming the test-event has a lot of implications 😅 |
My idea was to be explicit. The test event is a weekly recurring event and we use it for this case and while refactoring I thought it would be the cleaner way to rename it and to be clear about what the test is for. I wouldn't mind it too much if I had to name it back, but don't think it's ideal :) |
@JoeyStk it took longer than anticipated, but I finally fixed the tests. Could you have a look at my changes? |
Thank you soooo much! 😍 I'll check it out in a bit :) |
To me it looks and works as expected! So this PR is ready to have it's second review :) |
Short description
This PR refactors the event filters, adjusts the filters for long term events and adds a test.
Proposed changes
Side effects
Resolved issues
Fixes: #3379
Pull Request Review Guidelines