Pytest: Enable using markers #3392
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an oversight from #2297
PeterNerlich
added
bug
|
Btw, I also meant to ask in #3395 - do you have a working linter setup? 🙈 It's really useful to be able to get all of these messages without manually having to invoke the corresponding tools:
|
No, I always went bare editor and terminal until now. I dislike it if my machine spins away highlighting "mistakes" where I simply didn't finish writing the line yet, restarting the process every time I change anything. I prefer running those when I explicitly intend to. I will give it a try though now that we have ruff and see whether its performance can change my mind 😁 |
PeterNerlich
force-pushed
the
pytest/markers
branch
2 times, most recently
from
7f1c323 to
887c00e
Compare
Improve how tests selection is announced by the test script. Previously: $ tools/test.sh -m summ_ai_sanity -vv tests/summ_ai_sanity/ [...] Running all tests in with summ_ai_sanity, tests/summ_ai_sanity/... Now: $ tools/test.sh -m summ_ai_sanity -vv tests/summ_ai_sanity/ [...] Running all tests with summ_ai_sanity in "tests/summ_ai_sanity/"...
PeterNerlich
force-pushed
the
pytest/markers
branch
from
887c00e to
01bf138
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
While working on #2297 I made a mistake that left using markers dysfunctional.
Proposed changes
Side effects
If you relied on the functionality to completely ignore a marker when no keyword was specified or to ignore the given marker string and replace it with whatever you specified as keyword, then this will be a breaking change for youPull Request Review Guidelines