Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1875: Replaced pdf-lib #1931

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

1875: Replaced pdf-lib #1931

wants to merge 2 commits into from

Conversation

bahaaTuffaha
Copy link
Contributor

Short Description

Currently we use a very unsupported pdf-lib for our pdf generation (last release 4years+), so we should switch to better maintained fork.

Proposed Changes

  • Replaced the old one with its fork @cantoo/pdf-lib
  • Its also compatible with @pdf-lib/fontkit
    Note: I tested the this package on pdf creation at bayern and koblenz.

Side Effects

  • None.

Testing

  • Card creation for Koblenz, Bayern and Nuremberg and generate pdfs.

Resolved Issues

Fixes: #1875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenkleinle steffenkleinle Awaiting requested review from steffenkleinle steffenkleinle is a code owner

@f1sh1918 f1sh1918 Awaiting requested review from f1sh1918 f1sh1918 is a code owner

@ztefanie ztefanie Awaiting requested review from ztefanie ztefanie is a code owner

@seluianova seluianova Awaiting requested review from seluianova seluianova is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace pdf-lib
1 participant
@bahaaTuffaha