1912: Check and fix circular dependencies #1913
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1sh1918
force-pushed
the
1912-detect-circular-deps
branch
2 times, most recently
from
da5c3c9 to
d0ed239
Compare
f1sh1918
force-pushed
the
1912-detect-circular-deps
branch
2 times, most recently
from
1a1ce7d to
8ba139f
Compare
f1sh1918
changed the title
f1sh1918
force-pushed
the
1912-detect-circular-deps
branch
2 times, most recently
from
f735947 to
812bc82
Compare
f1sh1918
requested review from
steffenkleinle,
ztefanie and
seluianova
as code owners
f1sh1918
force-pushed
the
1912-detect-circular-deps
branch
3 times, most recently
from
1802ce2 to
c130690
Compare
f1sh1918
force-pushed
the
1912-detect-circular-deps
branch
3 times, most recently
from
549f9d6 to
0ff17e3
Compare
f1sh1918
force-pushed
the
1912-detect-circular-deps
branch
from
0ff17e3 to
ad5f85b
Compare
steffenkleinle
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
🙃 Rename to check_circular_deps (no .sh)
There was a problem hiding this comment.
❓ Is this copied from somewhere or did you write it yourself?
There was a problem hiding this comment.
Partly copied but adjusted to our needs . I will add the source
| @@ -117,7 +118,8 @@ | |||
| "format": "NODE_ENV=test eslint . --fix && prettier . --write", | |||
| "generate-graphql": "graphql-codegen --config graphql-codegen.yml", | |||
| "generate-protobuf": "protoc -I ../specs --es_out=src/generated --es_opt=target=ts --plugin=protoc-gen-es=../node_modules/.bin/protoc-gen-es ../specs/card.proto", | |||
| "postinstall": "npm run generate-protobuf && npm run generate-graphql" | |||
| "postinstall": "npm run generate-protobuf && npm run generate-graphql", | |||
| "check-circular-deps": "bash ./scripts/check_circular_deps.sh" | |||
There was a problem hiding this comment.
🔧 I think it would be better not to request bash explicitly.
Suggested change
| "check-circular-deps": "bash ./scripts/check_circular_deps.sh" | |
| "check-circular-deps": "./scripts/check_circular_deps" |
Perhaps you have to run chmod +x check_circular_deps first though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
To avoid circular dependencies i added
madgeto detect them.Since we got a couple of them, i provided some refactoring
Proposed Changes
add madge to detect circular dependencies
add bash script to check circular dependencies
execute bash script on
checkAdministrationin ci pipelinerefactor components and imports to solve circular dependencies (see screenshot)
add eslint config (couldn't test it yet)
TODO Refactor JsonFieldView & JsonFieldArray #1914 since this needs some more investigation
Side Effects
Testing
Note: That most of the changes are just imports and moving components in functions in separate files, so a rough code review should be sufficient
Resolved Issues
Fixes: #1912
Additional information