Skip to content

Conversation

@jameseaster
Copy link
Contributor

Resolves - replace html5-qrcode with barcode-detector


What kind of change does this PR introduce?

  • package, business logic, and UI update

What is the current behavior?

  • use html5-qrcode for camera scanner

What is the new behavior?

  • use barcode-detector for barcode detection and JS APIs for camera interaction

Does this PR introduce a breaking change?

  • no, same features are available

How has this been tested?

  • Locally scanned and verified credentials

Screenshots:

  • n/a

@jameseaster jameseaster marked this pull request as draft August 8, 2025 20:28
@jameseaster jameseaster marked this pull request as ready for review August 8, 2025 21:09
Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as this moves things forward to remove the deprecated dependency. We'll want future revisions to figure out what here ought to be further refactored into a reusable vanilla JS library.

<div class="fixed-full bg-black">
<!-- Video Stream -->
<div
id="video-container"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid id generally with reusable components, as an application could opt to put multiple components of the same kind on the same page. That being said, no need to change this right now, but it is something to consider when we refactor some of this scanner code into a reusable vanilla (non-framework-specific) JS API.

@jameseaster jameseaster merged commit 2ec2c3d into main Aug 11, 2025
3 checks passed
@jameseaster jameseaster deleted the barcode-detection-ponyfill branch August 11, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants