Skip to content

Fix Android camera bug #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlongley merged 3 commits into from
Jul 2, 2025
Merged

Fix Android camera bug #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dad26b5
Update camera config with a rounded value for aspect ratio.
jameseaster Jul 2, 2025
23b352a
Update changelog.
jameseaster Jul 2, 2025
c176738
Fix style.
dlongley Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# bedrock-vue-barcode-scanner ChangeLog

## 1.6.1 - 2025-07-dd

### Fixed
- Fix camera config to allow video stream to render back camera on Android.

## 1.6.0 - 2025-06-30

### Added
Expand Down
16 changes: 9 additions & 7 deletions components/BarcodeScanner.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,10 @@ export default {
const defaultCameraId =
backCameras.at(-1)?.deviceId ?? cameraList.value.at(-1)?.deviceId;
await scanner.start(
selectedCameraId.value ?? defaultCameraId,
getCameraScanConfig(), onScanSuccess, onError
);
{deviceId: {exact: selectedCameraId.value ?? defaultCameraId}},
getCameraScanConfig(),
onScanSuccess,
onError);
if(!selectedCameraId.value && cameraList.value.length) {
const selectedCamera = scanner.getRunningTrackSettings()?.deviceId;
updateSelectedCamera(selectedCamera);
Expand All @@ -108,7 +109,7 @@ export default {
}
await getZoomConstraints();
// Set focus mode
scanner.applyVideoConstraints({
await scanner.applyVideoConstraints({
advanced: [
{frameRate: 30},
{resizeMode: 'none'},
Expand Down Expand Up @@ -212,11 +213,12 @@ export default {
function getCameraScanConfig() {
const width = window.innerWidth;
const height = window.innerHeight;
const landscapeAspectRatio = width / height;
const portraitAspectRatio = height / width;
// must parse float aspect ratio value
const landscapeAspectRatio = parseFloat((width / height).toFixed(3));
const portraitAspectRatio = parseFloat((height / width).toFixed(3));
return {
videoConstraints: {
facingMode: 'environment',
facingMode: {exact: 'environment'},
aspectRatio: width < height ?
portraitAspectRatio :
landscapeAspectRatio
Expand Down