Add missing non-sensitive title #461
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manifest is part of document bundle sent to the server. A Portal.Job object might be newed up with a non-sensitive title, but this was lost in the mapping from Portal.Job to Manifest. This resulted in a bug which made it impossible for consumers of our dotnet client library to create portal jobs with non-sensitive tiles. Non-sensitive titles are titles that may be added in addition to "regular" titles. Non-sensitive titles may be displayed in contexts where we cannot ensure that people viewing are authorized, such as in email notificaitons sent to signers.
Contributor
Author
|
This bug was already fixed with the release of version 10.0.1. 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💰 Funksjonell beskrivelse av endringen
Manifest is part of document bundle sent to the server.
A Portal.Job object might be newed up with a non-sensitive title, but this was lost in the mapping from Portal.Job to Manifest. This resulted in a bug which made it impossible for consumers of our dotnet client library to create portal jobs with non-sensitive tiles.
Non-sensitive titles are titles that may be added in addition to "regular" titles. Non-sensitive titles may be displayed in contexts where we cannot ensure that people viewing are authorized, such as in email notificaitons sent to signers.
🏆 Interessante highlights
Usikkerheter, avveininger og andre ting som kan være interessant å se på
🤷♀️ Anbefalt fremgangsmåte
Hvordan bør pull requesten angripes? Commit for commit? Hele smæla på en gang? Gjennomgang i fellesskap IRL?
👀 Eksempler og screenshots
Har du gjort en API-endring? Vis et request! Har du endret i GUI? Ta et screenshot!
⚙️ Avhengigheter
Er koden avhengig av en endring i for eksempel frontend eller API-klienten? Sleng inn en link til relevante pull requests her
🚔 Sikkerhet
Hvordan er de viktigste sikkerhetsaspektene ivaretatt? Her er det lov til å slette ting som ikke er relevante, men det er kjempeviktig at du har vurdert relevansen av alt!