-
Notifications
You must be signed in to change notification settings - Fork 21
skpkg: misc config and other file changes #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## migration #344 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 9 9
Lines 516 516
===========================================
Hits 516 516 🚀 New features to boost your workflow:
|
I believe it is already in |
@sbillinge Oh you're right, I must've got rid of it when I moved requirements over! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. I am confused now, because I believe that copybutton
is in skpkg 0.1.0 so I am not sure why you are having to manually add it here. Please see my other comment and then I an merge.
@sbillinge see above response about copybutton, it was a fault on my end! |
slow and steady wins the race! |
Brilliant, is that a wrap (bar testing)? |
@sbillinge yep! |
@sbillinge pytest passes on a fully sync'd migration branch. Is there any other testing that needs to be done? |
normally we would quickly run through any tutorial. Could you take a look if there is one? But then we can merge. I htink you can create a PR, migration -> main when you are ready. |
@cadenmyers13 don't forget the "closes #" close the skpkg issue for that migration -> main PR. |
@sbillinge will do. There are tutorials for this. ill run them and let you know if i run into any bugs |
Final PR for the current skpkg'ing of diffpy.utils! After this is merged we should be able to merge
migration
intomain
once tested.I had to install
sphinx-copybutton
to build docs locally so i added that to requirements. Maybe this needs to be added toscikit-package
?