skpkg: doc migration #342
Merged
skpkg: doc migration #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## migration #342 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 9 9
Lines 516 516
===========================================
Hits 516 516 🚀 New features to boost your workflow:
|
|
thanks @cadenmyers13 I saw your note. We can look into those formatting warnings on another PR. For now, this is nicely done to bring things up to skpkg 0.1.0 standards which is the current task at hand so I merged. I appreciate you creating the issue for that other work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I built docs locally, I got a lot of warning messages referring to docstring formatting and other doc formatting. However, these warnings persists on the current version of diffpy.utils leading me to believe that there are some formatting issues with the current rst files where the docs exists (which i left unchanged).