Skip to content

Fix get_array_index returns int instead of list in DiffractionObject #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2024
Merged

Fix get_array_index returns int instead of list in DiffractionObject #283

merged 1 commit into from
Dec 27, 2024

Conversation

@bobleesj
Copy link
Contributor

Closes #279

@bobleesj bobleesj changed the title Fix test function to check get_array_index returns int instead of list Fix get_array_index returns int instead of list in DiffractionObject Dec 27, 2024
bobleesj
bobleesj commented Dec 27, 2024
View reviewed changes
@codecov
Copy link

codecov bot commented Dec 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b0b6676) to head (faf0e2f).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #283   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          405       405           
=========================================
  Hits           405       405
Files with missing lines Coverage Δ
tests/test_diffraction_objects.py 100.00% <100.00%> (ø)

bobleesj
bobleesj commented Dec 27, 2024
View reviewed changes
bobleesj
bobleesj commented Dec 27, 2024
View reviewed changes
bobleesj
bobleesj commented Dec 27, 2024
View reviewed changes
Copy link
Contributor Author

@bobleesj bobleesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for review @sbillinge

@sbillinge sbillinge merged commit 5a31716 into diffpy:main Dec 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

get_array_index returns list, instead should be int

2 participants

@bobleesj @sbillinge