Skip to content

Conversation

TingwenZhang
Copy link
Contributor

@TingwenZhang TingwenZhang commented Jun 1, 2025

@sbillinge
Could you take a look?

Closes #125

@sbillinge
Copy link
Contributor

Thanks @TingwenZhang . please confirm what you did to check that none of the files changed are referred to anywhere.

Also, does this close an issue? Make sure to type closes # where you replace # with the issue number.

@TingwenZhang
Copy link
Contributor Author

Yes, none of the files are referenced elsewhere. I added Closes #125.

@sbillinge sbillinge merged commit 4065098 into diffpy:main Jun 2, 2025
1 check passed
@sbillinge
Copy link
Contributor

thanks @TingwenZhang

btw, that should have been chore, not chored :). A chore is a boring but required task like doing the dishes or taking out the trash. I get that you maybe wanted to make it into the past tense on the PR! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: ensure correct usage of underscores and hyphens for file and folder names
2 participants