skpkg: fix migrated tests #38
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponents Signed-off-by: Dasun Abeykoon <[email protected]>
…ectories Signed-off-by: Dasun Abeykoon <[email protected]>
Signed-off-by: Dasun Abeykoon <[email protected]>
Signed-off-by: Dasun Abeykoon <[email protected]>
|
Currently, it seems that while running 'test_nmf_mapping_code' the actual output is different than the expected output causing the tests to fail. It also probably isn't a formatting issue, as after reverting the pre-commit changes to the expected output the tests still fail. |
sbillinge
reviewed
Jun 29, 2025
| @@ -15,6 +15,7 @@ repos: | |||
| hooks: | |||
| - id: check-yaml | |||
| - id: end-of-file-fixer | |||
| exclude: ^tests/output/ | |||
tests/test_NMF_analysis_code.py
Outdated
| @@ -12,12 +12,12 @@ | |||
| data_dir = os.path.join(dir, "data/synthetic_r_vs_gr") | |||
|
|
|||
| test_map = [ | |||
| ([data_dir, "--xrange", "5,10"], "output_1", "Number of components: 3\n"), | |||
| ([data_dir], "output_2", "Number of components: 3\n"), | |||
| ([data_dir, "--xrange", "5,10"], "output_1", "Number of components: 10"), | |||
There was a problem hiding this comment.
rather than change the number of components from 3 to 10 in the output, maybe set the number of components to 3 in CLI inputs? I am not sure the flag for that, but it will be in the arg parser.
Signed-off-by: Dasun Abeykoon <[email protected]>
|
Since the plan is to fix the tests later on after the migration process, I'll just close this PR for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.