Skip to content

Python Interfacing for PDFmorph (Clean Branch) #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Sparks29032
Copy link
Collaborator

@Sparks29032 Sparks29032 commented Apr 29, 2025

Todo:

  • Add tests
  • Add news
  • Edit functions or function descriptions to include some common kwargs
  • Update documentation
  • Add tutorial rst

Copy link

codecov bot commented Apr 29, 2025

Codecov Report

Attention: Patch coverage is 98.38710% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.19%. Comparing base (a450cd7) to head (e2362b2).

Files with missing lines Patch % Lines
tests/test_morphpy.py 98.38% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
+ Coverage   97.11%   97.19%   +0.08%     
==========================================
  Files          20       21       +1     
  Lines         866      928      +62     
==========================================
+ Hits          841      902      +61     
- Misses         25       26       +1     
Files with missing lines Coverage Δ
tests/test_morphpy.py 98.38% <98.38%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sparks29032 Sparks29032 mentioned this pull request Apr 29, 2025
5 tasks
@Sparks29032 Sparks29032 reopened this Apr 29, 2025
@sbillinge
Copy link
Contributor

@Luiskitsu please could you look at this. We may have battling pianos here so i want to synchronize efforts. Also, this is a big PR that is coming from a bunch of work we were doing at another XFEL beamtime and it is hard to review such a big PR so more eyes on it would be good. In general, it would be good to arrange a quick face to face meeting to discuss everything and make sure we are pushing together in the same direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants