Cookie Cutter + PyPi fix #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sparks29032 I am happy to merge, thanks for the work on this. Normally I don't like merging things with force-pushes in though. Please don't force-push. |
Merged
|
Got it, I'll consolidate pre-commit next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cookiecutter, standard stuff.
Also added contents to
pip.txt. This is the same asrun.txtexceptmatplotlib-baseis changed tomatplotlib. This is becausematplotlib-baseis not available onPyPi, and cannot bepiporpipx(Tom's suggestion) installed. This does not bloat ourconda-forgerelease, which usesrun.txt, but it ensures anything building or installing withpippulls the correct package.Below is the result without this fix:
