Skip to content

load package info #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2024
Merged

load package info #79

merged 2 commits into from
Jun 20, 2024

Conversation

yucongalicechen
Copy link
Collaborator

closes #28

sbillinge
sbillinge reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there may be a good reason, but why is there a merge of main into this branch?

@yucongalicechen
Copy link
Collaborator Author

there may be a good reason, but why is there a merge of main into this branch?

I merged because I wasn't super sure if it could find the moker I updated previously.. maybe not necessary?

@sbillinge
Copy link
Contributor

was it failing tests because it couldn't find that? that would be the way to tell.

It is ok, I can merge it like this, but please practice good git hygiene.....don't merge main into branch unless absolutely needed.

@sbillinge sbillinge merged commit f6b2ba4 into diffpy:main Jun 20, 2024
3 checks passed
@yucongalicechen yucongalicechen deleted the pkg branch June 21, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbillinge sbillinge sbillinge left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

load the name of the package and the version number into metadata
2 participants
@yucongalicechen @sbillinge