Skip to content

GH action to build and deploy docs #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

GH action to build and deploy docs #71

wants to merge 5 commits into from

Conversation

cadenmyers13
Copy link
Contributor

@cadenmyers13 cadenmyers13 commented May 23, 2024

closes #56

Created a new PR because I was pushing from main on the other one.

This should fix the flake8 pre-commit issue

cadenmyers13 and others added 5 commits May 20, 2024 15:06

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cadenmyers13 . I think we are not doing the pull_request: and the related if in doc.yml

Also, I am worried that your main is not clean as I keep seeing a commit in your PRs which is a merge of main. Also there are multiple things on this PR.

I could merge it like this (when you fix the pull_request:), but it would be good to make sure everything is ok with your setup and your workflows, so I suggest that you make a new PR on a clean branch that just does the GH action and nothing else.

@cadenmyers13
Copy link
Contributor Author

Thanks @cadenmyers13 . I think we are not doing the pull_request: and the related if in doc.yml

Also, I am worried that your main is not clean as I keep seeing a commit in your PRs which is a merge of main. Also there are multiple things on this PR.

I could merge it like this (when you fix the pull_request:), but it would be good to make sure everything is ok with your setup and your workflows, so I suggest that you make a new PR on a clean branch that just does the GH action and nothing else.

Yeah I've kind of made a mess with my branches. After this PR, i will sort everything out

@sbillinge
Copy link
Contributor

closing PR so we can sort out branches and do it cleanly.

@sbillinge sbillinge closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documents and build
2 participants