-
Notifications
You must be signed in to change notification settings - Fork 11
Support 3.12 CI - conda install wxPython
, pip install gooey
- to prevent building wxPython
#137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Warning! No news item is found for this PR. If this is a user-facing change/feature/fix, |
(Not ready for review) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
=======================================
Coverage 99.31% 99.31%
=======================================
Files 6 6
Lines 293 293
=======================================
Hits 291 291
Misses 2 2 |
.github/workflows/tests-on-pr.yml
Outdated
@@ -13,7 +13,7 @@ jobs: | |||
run: | |||
shell: bash -l {0} | |||
|
|||
runs-on: ubuntu-latest | |||
runs-on: macos-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turns out wxpython
needs to be built for linux since no native whl is provided while we have windows/macos whl files provided shown below:

Since @yucongalicechen and I test using macOS, what if we setup a MacOS CI instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move back to Linux after we add wxpython to conda.txt
@@ -2,4 +2,3 @@ numpy | |||
diffpy.utils | |||
pandas | |||
scipy | |||
gooey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed gooey from conda.txt
since we won't be able to install it and it will only fail the CI during conda install.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to add wxpython to conda.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, done.
@sbillinge ready for review. pls see in-line comments. Thank you. |
@yucongalicechen tagging Yucong as well to share what's going on here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does adding wxpython to conda.txt allow you to set it back to Linux-latest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be cleaner to close this and redo following the regolith protocol
@@ -2,4 +2,3 @@ numpy | |||
diffpy.utils | |||
pandas | |||
scipy | |||
gooey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to add wxpython to conda.txt
.github/workflows/tests-on-pr.yml
Outdated
@@ -13,7 +13,7 @@ jobs: | |||
run: | |||
shell: bash -l {0} | |||
|
|||
runs-on: ubuntu-latest | |||
runs-on: macos-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move back to Linux after we add wxpython to conda.txt
@@ -32,15 +32,11 @@ jobs: | |||
conda config --set always_yes yes | |||
--set changeps1 no | |||
|
|||
- name: Install libgtk for Linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libgtk
is no longer needed. here, wxpython is install via conda-forge as suggested.
wxPython
, pip install gooey
- to prevent building wxPython
@sbillinge ready for review - thanks for the suggestion. wxpython is conda-installed as suggested while gooey is pip installed. |
nice. Much cleaner. |
No description provided.