Workspaces 1/10: Workspace strip, hidden-Workspace minimize

[nedtwigg]

First stage of the Workspaces stack: the Workspace membership, session, and Wall-handle registries; one Wall per Workspace composed in one grid cell; the strip in the standalone app bar; command-mode shortcuts; stories.

Merged over origin/main (#611, #612). A hidden Workspace's terminals now go through the minimize primitives — detached and GL-released on deactivation, remounted through the fit gate on activation with no PTY resize at an unchanged grid — since a visibility:hidden box still intersects and xterm kept rasterizing.

Stack: 1/10 → workspaces-persist → workspaces-multiwindow → workspaces-dor → workspaces-harden → workspaces-registry → workspaces-durability → workspaces-fidelity → workspaces-move-verb → workspaces-harness.

Not verified in this PR: the WKWebView checks (context release in Safari Web Inspector, one-frame blank on switch-back, switch latency into many panes) — #612 was validated only in Chromium.

🤖 Generated with Claude Code

https://claude.ai/code/session_01PkPyEFCxiPo5UFeju5Ya9u

[cloudflare-workers-and-pages]

Deploying mouseterm with    Cloudflare Pages

Latest commit:	61ac0be
Status:	✅  Deploy successful!
Preview URL:	https://60cc490d.mouseterm.pages.dev
Branch Preview URL:	https://workspaces-window.mouseterm.pages.dev

View logs

[dormouse-bot]

Feedback on work in progress — not a merge verdict. Mark the PR ready when you want the full review.

Four of the five inline findings are reachable today; the fifth is a spec line that now contradicts itself. The highest-impact one is the stranded renamingId: it is a one-gesture path to a session where command mode never dispatches again.

One observation with no inline home, because the code it concerns has never executed: the SaveSink path is unreachable while PERSIST_SESSION = false in both standalone adapters, so two of its seams are unexercised. publishedRef starts null and is only ever written by publish, so SaveSink.previous's own claim — "This Workspace's last persisted record; the previous-pane map reads a dead PTY's retained cwd out of it" — is false for the first save of every boot; the old readPersistedSession(platform.getState()) read the restored record on every save including the first, so a restored pane whose PTY is dead would keep its retained cwd and alert where the sink path drops both. And closeWorkspaceWithSurfaces calls forgetWorkspaceSession(id) synchronously, but the Wall unmounts a render later and its persistence cleanup ends with void persistSessionNow(), which republishes through the sink — re-inserting the entry that was just forgotten. getWindowSnapshot() filters against the Workspace store so the emitted snapshot stays right, but sessions grows one PersistedSession per closed Workspace and the writer, once installed, gets a spurious call per close. Both are worth settling before the writer lands rather than after, since neither will show up as a failing test until it does.

[dormouse-bot]

Feedback on work in progress — not a merge verdict. Mark the PR ready when you want the full review.

All five earlier findings are closed out: the close verb now clears the lease, the spacer carries data-tauri-drag-region with a floor, the rename editor no longer starts a reorder, bare Shift/Meta no longer answer the confirmation, and I4 reads consistently. I re-derived the handleDualTap claim the new comment makes — Meta and Shift are the only keys it consumes, so Control and Alt still dismiss both confirmations, and the filter is faithful.

One new finding on the increment, inline: the clear is unscoped, so closing one Workspace drops another's open rename editor or on-screen confirmation.

[dormouse-bot]

Feedback on work in progress — not a merge verdict. Mark the PR ready when you want the full review.

The scoped clear closes out the previous round's finding, and the new test pins it against the unconditional form. One finding on the increment, inline: layout.md's rule narrowed with the code, but the clause explaining it and the test it names still describe the rule before the narrowing.

[dormouse-bot]

The narrowing landed in the code, but this line's why-clause and its cited test still describe the rule before it was narrowed.

a stale renamingId holds the chrome keyboard lease for the session is the consequence of not dropping — it says nothing about what goes wrong if a close drops more than its own, which is now the emphasized half of the rule. And the pin is WorkspaceStrip.test.tsx, whose releases the rename lease when the tab being renamed is middle-clicked closed covers only the same-Workspace case; the sibling-preservation half is pinned by workspace-lifecycle.test.ts's new preserves another Workspace's rename and close confirmation when closing a sibling, which this line doesn't name. A maintainer who later widens the clear back to the unconditional form reads a rule whose stated consequence it still satisfies and whose named test still passes.

Moving only out of the bold predicate and into a trailing and no other's keeps one bolded imperative with one why-clause, and names both pins (8393/8400 words — no re-ratchet):

Suggested change

**Create** adds a Workspace named `Workspace N`, makes it active, and gives its Wall no restored record, so Lath's fresh branch spawns one default-shell pane. **Close** confirms first when the Workspace holds touched Surfaces or running work, reusing the kill-confirm letter and key rule over the Window's content area (**a bare `Shift` or `Meta` is not an answer**, as for a pane kill), then routes every member Surface through the closure coordinator; **the last remaining Workspace cannot be closed** — there is always one active Workspace, as there is always one visible pane (corner case #5). **One close runs at a time for the whole Window**, with the count re-checked after the confirmation, so two of them cannot empty two Walls between them; **a close the store then refuses hands the Wall back its auto-spawn** rather than leaving it mounted and empty. **Rename** edits the Workspace `name` only — no Surface title, and not the per-pane inline rename. **Reorder** moves a tab in the strip and renumbers the positional `workspace:<n>` refs with it; **a press inside the open rename editor never starts a reorder**. **Must drop only the closing Workspace’s rename editor and pending confirmation**, or a stale `renamingId` holds the chrome keyboard lease for the session (`WorkspaceStrip.test.tsx`). **Every Workspace verb runs outside the strip**, which renders the rename editor and confirmation from a store, so a tab gesture and a command-mode key take one path.

**Create** adds a Workspace named `Workspace N`, makes it active, and gives its Wall no restored record, so Lath's fresh branch spawns one default-shell pane. **Close** confirms first when the Workspace holds touched Surfaces or running work, reusing the kill-confirm letter and key rule over the Window's content area (**a bare `Shift` or `Meta` is not an answer**, as for a pane kill), then routes every member Surface through the closure coordinator; **the last remaining Workspace cannot be closed** — there is always one active Workspace, as there is always one visible pane (corner case #5). **One close runs at a time for the whole Window**, with the count re-checked after the confirmation, so two of them cannot empty two Walls between them; **a close the store then refuses hands the Wall back its auto-spawn** rather than leaving it mounted and empty. **Rename** edits the Workspace `name` only — no Surface title, and not the per-pane inline rename. **Reorder** moves a tab in the strip and renumbers the positional `workspace:<n>` refs with it; **a press inside the open rename editor never starts a reorder**. **Must drop the closing Workspace’s rename editor and pending confirmation, and no other’s** — a stale `renamingId` holds the chrome keyboard lease for the session (`WorkspaceStrip.test.tsx`, `workspace-lifecycle.test.ts`). **Every Workspace verb runs outside the strip**, which renders the rename editor and confirmation from a store, so a tab gesture and a command-mode key take one path.