Skip to content

CI: Remove use of Ubuntu 20.04 #8613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 4, 2025
Merged

CI: Remove use of Ubuntu 20.04 #8613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5d54c6
Library test no longer fails on Ubuntu 24.04
tautschnig Apr 2, 2025
30bd93d
Apply use-after-free and empty-symbol-table fixes to Linux 5.10
tautschnig Apr 3, 2025
7540c49
Address include-what-you-use warnings
tautschnig Apr 3, 2025
850dfa5
CI: Remove use of Ubuntu 20.04
tautschnig Apr 2, 2025
32d6835
Include-what-you-use: use clang to avoid spurious errors
tautschnig Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions .github/workflows/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,22 @@ The files in this folder correspond to:

We are currently building and testing CBMC under the following configurations:

* `make` * `gcc` * `linux` (ubuntu 20.04)
* `make` * `clang` * `linux` (ubuntu 20.04)
* `cmake` * `gcc` * `linux` (ubuntu 20.04)
* `make` * `clang` * `macos` (10.15)
* `cmake` * `clang` * `macos` (10.15)
* `make` * `gcc` * `linux` (ubuntu 24.04)
* `make` * `clang` * `linux` (ubuntu 22.04, 24.04)
* `cmake` * `gcc` * `linux` (ubuntu 22.04, 24.04)
* `cmake` * `gcc-14` * `linux` (ubuntu 24.04)
* `cmake` * `gcc` * `linux` (ubuntu 22.04 32-bit)
* `make` * `clang` * `macos` (13)
* `cmake` * `clang` * `macos` (14)
* `cmake` * `vs` * `windows` (vs2019)
* `make` * `vs` * `windows` (vs2022)

Aside from the main platform builds for testing, we are also performing
some auxiliary builds that test packaging support to be up-to-date. We
do that for:

* a `docker` image
* an `ubuntu-20.04` package
* a `ubuntu-24.04` package
* a `windows-msi` installer package

Last but not least, we are also performing a coverage statistics collection
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/build-and-test-Linux.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
jobs:
# This job takes approximately 18 minutes
CompileLinux:
runs-on: ubuntu-20.04
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -20,7 +20,7 @@ jobs:
DEBIAN_FRONTEND: noninteractive
run: |
sudo apt-get update
sudo apt-get install --no-install-recommends -y clang-10 clang++-10 flex bison cmake ninja-build maven jq libxml2-utils dpkg-dev ccache
sudo apt-get install --no-install-recommends -y clang-19 clang++-19 flex bison cmake ninja-build maven jq libxml2-utils dpkg-dev ccache
sudo apt-get install --no-install-recommends -y libssl-dev libelf-dev libudev-dev libpci-dev libiberty-dev autoconf
sudo apt-get install --no-install-recommends -y gawk jq

Expand All @@ -29,10 +29,10 @@ jobs:
with:
save-always: true
path: .ccache
key: ${{ runner.os }}-20.04-make-clang-${{ github.ref }}-${{ github.sha }}-KERNEL
key: ${{ runner.os }}-24.04-make-clang-${{ github.ref }}-${{ github.sha }}-KERNEL
restore-keys: |
${{ runner.os }}-20.04-make-clang-${{ github.ref }}
${{ runner.os }}-20.04-make-clang
${{ runner.os }}-24.04-make-clang-${{ github.ref }}
${{ runner.os }}-24.04-make-clang
- name: ccache environment
run: |
echo "CCACHE_BASEDIR=$PWD" >> $GITHUB_ENV
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/build-and-test-Xen.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
jobs:
# This job takes approximately 33 minutes
CompileXen:
runs-on: ubuntu-20.04
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -19,19 +19,19 @@ jobs:
DEBIAN_FRONTEND: noninteractive
run: |
sudo apt-get update
sudo apt-get install --no-install-recommends -y build-essential git flex bison software-properties-common curl python
sudo apt-get install --no-install-recommends -y bin86 gdb bcc liblzma-dev python-dev gettext iasl uuid-dev libncurses5-dev libncursesw5-dev pkg-config
sudo apt-get install --no-install-recommends -y libgtk2.0-dev libyajl-dev time ccache clang-10 clang++-10
sudo apt-get install --no-install-recommends -y build-essential git flex bison software-properties-common curl python3
sudo apt-get install --no-install-recommends -y bin86 gdb bcc liblzma-dev python3-dev gettext iasl uuid-dev libncurses5-dev libncursesw5-dev pkg-config
sudo apt-get install --no-install-recommends -y libgtk2.0-dev libyajl-dev time ccache clang-19 clang++-19

- name: Prepare ccache
uses: actions/cache@v4
with:
save-always: true
path: .ccache
key: ${{ runner.os }}-20.04-make-clang-${{ github.ref }}-${{ github.sha }}-XEN
key: ${{ runner.os }}-24.04-make-clang-${{ github.ref }}-${{ github.sha }}-XEN
restore-keys: |
${{ runner.os }}-20.04-make-clang-${{ github.ref }}
${{ runner.os }}-20.04-make-clang
${{ runner.os }}-24.04-make-clang-${{ github.ref }}
${{ runner.os }}-24.04-make-clang
- name: ccache environment
run: |
echo "CCACHE_BASEDIR=$PWD" >> $GITHUB_ENV
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/coverage.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ env:
jobs:
# This job takes approximately 22 to 75 minutes
Linux:
runs-on: ubuntu-20.04
runs-on: ubuntu-24.04
steps:
- name: Clone repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -45,10 +45,10 @@ jobs:
with:
save-always: true
path: .ccache
key: ${{ runner.os }}-20.04-Coverage-${{ github.ref }}-${{ github.sha }}-PR
key: ${{ runner.os }}-24.04-Coverage-${{ github.ref }}-${{ github.sha }}-PR
restore-keys: |
${{ runner.os }}-20.04-Coverage-${{ github.ref }}
${{ runner.os }}-20.04-Coverage
${{ runner.os }}-24.04-Coverage-${{ github.ref }}
${{ runner.os }}-24.04-Coverage
- name: ccache environment
run: |
echo "CCACHE_BASEDIR=$PWD" >> $GITHUB_ENV
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/csmith.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
jobs:
# This job takes approximately 18 minutes
run-10-random-tests:
runs-on: ubuntu-20.04
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -19,18 +19,18 @@ jobs:
DEBIAN_FRONTEND: noninteractive
run: |
sudo apt-get update
sudo apt-get install --no-install-recommends -y build-essential flex bison maven ccache clang-10 clang++-10
sudo apt-get install --no-install-recommends -y build-essential flex bison maven ccache clang-19 clang++-19
sudo apt-get install --no-install-recommends -y csmith libcsmith-dev
make -C src minisat2-download
- name: Prepare ccache
uses: actions/cache@v4
with:
save-always: true
path: .ccache
key: ${{ runner.os }}-20.04-make-clang-${{ github.ref }}-${{ github.sha }}-CSMITH
key: ${{ runner.os }}-24.04-make-clang-${{ github.ref }}-${{ github.sha }}-CSMITH
restore-keys: |
${{ runner.os }}-20.04-make-clang-${{ github.ref }}
${{ runner.os }}-20.04-make-clang
${{ runner.os }}-24.04-make-clang-${{ github.ref }}
${{ runner.os }}-24.04-make-clang
- name: ccache environment
run: |
echo "CCACHE_BASEDIR=$PWD" >> $GITHUB_ENV
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/doxygen-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
check-doxygen:
# Note that the versions used for this `check-doxygen` job should be kept in
# sync with the `publish` job.
runs-on: ubuntu-24.04
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Fetch dependencies
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/performance.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

jobs:
perf-benchcomp:
runs-on: ubuntu-20.04
runs-on: ubuntu-24.04
steps:
- name: Save push event HEAD and HEAD~ to environment variables
if: ${{ github.event_name == 'push' }}
Expand Down Expand Up @@ -51,10 +51,10 @@ jobs:
uses: actions/cache/restore@v4
with:
path: .ccache
key: ${{ runner.os }}-20.04-Release-${{ github.ref }}-${{ github.sha }}-PR
key: ${{ runner.os }}-24.04-Release-${{ github.ref }}-${{ github.sha }}-PR
restore-keys: |
${{ runner.os }}-20.04-Release-${{ github.ref }}
${{ runner.os }}-20.04-Release
${{ runner.os }}-24.04-Release-${{ github.ref }}
${{ runner.os }}-24.04-Release
- name: ccache environment
run: echo "CCACHE_DIR=$PWD/.ccache" >> $GITHUB_ENV
- name: Zero ccache stats and limit in size
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
publish:
# Note that the versions used for this `publish` job should be kept in sync
# with the `check-doxygen` job.
runs-on: ubuntu-24.04
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4
Expand Down
74 changes: 37 additions & 37 deletions .github/workflows/pull-request-checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ env:

jobs:
# This job takes approximately 15 to 40 minutes
check-ubuntu-20_04-make-gcc:
runs-on: ubuntu-20.04
check-ubuntu-24_04-make-gcc:
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -38,10 +38,10 @@ jobs:
with:
save-always: true
path: .ccache
key: ${{ runner.os }}-20.04-make-${{ github.ref }}-${{ github.sha }}-PR
key: ${{ runner.os }}-24.04-make-${{ github.ref }}-${{ github.sha }}-PR
restore-keys: |
${{ runner.os }}-20.04-make-${{ github.ref }}
${{ runner.os }}-20.04-make
${{ runner.os }}-24.04-make-${{ github.ref }}
${{ runner.os }}-24.04-make
- name: ccache environment
run: |
echo "CCACHE_BASEDIR=$PWD" >> $GITHUB_ENV
Expand Down Expand Up @@ -92,8 +92,8 @@ jobs:
fi

# This job takes approximately 25 to 34 minutes
check-ubuntu-20_04-make-clang:
runs-on: ubuntu-20.04
check-ubuntu-24_04-make-clang:
runs-on: ubuntu-24.04
env:
CC: "ccache /usr/bin/clang"
CXX: "ccache /usr/bin/clang++"
Expand All @@ -108,7 +108,7 @@ jobs:
DEBIAN_FRONTEND: noninteractive
run: |
sudo apt-get update
sudo apt-get install --no-install-recommends -yq clang-10 clang++-10 gdb maven jq flex bison libxml2-utils cpanminus ccache z3
sudo apt-get install --no-install-recommends -yq clang-19 clang++-19 gdb maven jq flex bison libxml2-utils cpanminus ccache z3
make -C src minisat2-download cadical-download
cpanm Thread::Pool::Simple
- name: Confirm z3 solver is available and log the version installed
Expand All @@ -124,10 +124,10 @@ jobs:
with:
save-always: true
path: .ccache
key: ${{ runner.os }}-20.04-make-clang-${{ github.ref }}-${{ github.sha }}-PR
key: ${{ runner.os }}-24.04-make-clang-${{ github.ref }}-${{ github.sha }}-PR
restore-keys: |
${{ runner.os }}-20.04-make-clang-${{ github.ref }}
${{ runner.os }}-20.04-make-clang
${{ runner.os }}-24.04-make-clang-${{ github.ref }}
${{ runner.os }}-24.04-make-clang
- name: ccache environment
run: |
echo "CCACHE_BASEDIR=$PWD" >> $GITHUB_ENV
Expand Down Expand Up @@ -165,8 +165,8 @@ jobs:
# The reason we opted for a new job is that adding a `test-z3` step to the current
# jobs increases the job runtime to unacceptable levels (over 2hrs).
# This job takes approximately 3 to 18 minutes
check-ubuntu-20_04-make-clang-smt-z3:
runs-on: ubuntu-20.04
check-ubuntu-24_04-make-clang-smt-z3:
runs-on: ubuntu-24.04
env:
CC: "ccache /usr/bin/clang"
CXX: "ccache /usr/bin/clang++"
Expand All @@ -179,7 +179,7 @@ jobs:
DEBIAN_FRONTEND: noninteractive
run: |
sudo apt-get update
sudo apt-get install --no-install-recommends -yq clang-10 clang++-10 gdb maven jq flex bison libxml2-utils cpanminus ccache z3
sudo apt-get install --no-install-recommends -yq clang-19 clang++-19 gdb maven jq flex bison libxml2-utils cpanminus ccache z3
make -C src minisat2-download
cpanm Thread::Pool::Simple
- name: Confirm z3 solver is available and log the version installed
Expand All @@ -189,10 +189,10 @@ jobs:
with:
save-always: true
path: .ccache
key: ${{ runner.os }}-20.04-make-clang-${{ github.ref }}-${{ github.sha }}-PR
key: ${{ runner.os }}-24.04-make-clang-${{ github.ref }}-${{ github.sha }}-PR
restore-keys: |
${{ runner.os }}-20.04-make-clang-${{ github.ref }}
${{ runner.os }}-20.04-make-clang
${{ runner.os }}-24.04-make-clang-${{ github.ref }}
${{ runner.os }}-24.04-make-clang
- name: ccache environment
run: |
echo "CCACHE_BASEDIR=$PWD" >> $GITHUB_ENV
Expand All @@ -207,8 +207,8 @@ jobs:
run: make -C regression/cbmc test-z3

# This job takes approximately 17 to 42 minutes
check-ubuntu-20_04-cmake-gcc:
runs-on: ubuntu-20.04
check-ubuntu-24_04-cmake-gcc:
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -234,10 +234,10 @@ jobs:
with:
save-always: true
path: .ccache
key: ${{ runner.os }}-20.04-Release-${{ github.ref }}-${{ github.sha }}-PR
key: ${{ runner.os }}-24.04-Release-${{ github.ref }}-${{ github.sha }}-PR
restore-keys: |
${{ runner.os }}-20.04-Release-${{ github.ref }}
${{ runner.os }}-20.04-Release
${{ runner.os }}-24.04-Release-${{ github.ref }}
${{ runner.os }}-24.04-Release
- name: ccache environment
run: |
echo "CCACHE_BASEDIR=$PWD" >> $GITHUB_ENV
Expand Down Expand Up @@ -499,8 +499,8 @@ jobs:
run: cd build; ctest . -V -L CORE -j${{env.linux-vcpus}}

# This job takes approximately 2 to 24 minutes
check-ubuntu-20_04-cmake-gcc-KNOWNBUG:
runs-on: ubuntu-20.04
check-ubuntu-24_04-cmake-gcc-KNOWNBUG:
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -518,10 +518,10 @@ jobs:
with:
save-always: true
path: .ccache
key: ${{ runner.os }}-20.04-Release-${{ github.ref }}-${{ github.sha }}-PR
key: ${{ runner.os }}-24.04-Release-${{ github.ref }}-${{ github.sha }}-PR
restore-keys: |
${{ runner.os }}-20.04-Release-${{ github.ref }}
${{ runner.os }}-20.04-Release
${{ runner.os }}-24.04-Release-${{ github.ref }}
${{ runner.os }}-24.04-Release
- name: ccache environment
run: |
echo "CCACHE_BASEDIR=$PWD" >> $GITHUB_ENV
Expand All @@ -546,8 +546,8 @@ jobs:
../test.pl -c "cbmc --cprover-smt2" -I broken-smt-backend -K

# This job takes approximately 7 to 30 minutes
check-ubuntu-20_04-cmake-gcc-THOROUGH:
runs-on: ubuntu-20.04
check-ubuntu-24_04-cmake-gcc-THOROUGH:
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -565,10 +565,10 @@ jobs:
with:
save-always: true
path: .ccache
key: ${{ runner.os }}-20.04-Release-${{ github.ref }}-${{ github.sha }}-PR
key: ${{ runner.os }}-24.04-Release-${{ github.ref }}-${{ github.sha }}-PR
restore-keys: |
${{ runner.os }}-20.04-Release-${{ github.ref }}
${{ runner.os }}-20.04-Release
${{ runner.os }}-24.04-Release-${{ github.ref }}
${{ runner.os }}-24.04-Release
- name: ccache environment
run: |
echo "CCACHE_BASEDIR=$PWD" >> $GITHUB_ENV
Expand Down Expand Up @@ -877,15 +877,15 @@ jobs:

# This job takes approximately 2 to 3 minutes
check-string-table:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Check for unused irep ids
run: ./scripts/string_table_check.sh

# This job takes approximately 23 to 29 minutes
check-docker-image:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -909,7 +909,7 @@ jobs:

# This job takes approximately 22 to 41 minutes
include-what-you-use:
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -921,9 +921,9 @@ jobs:
DEBIAN_FRONTEND: noninteractive
run: |
sudo apt-get update
sudo apt-get install --no-install-recommends -yq cmake ninja-build gcc gdb g++ maven flex bison iwyu
sudo apt-get install --no-install-recommends -yq cmake ninja-build clang-19 clang++-19 gdb maven flex bison iwyu
- name: Configure using CMake
run: cmake -S . -Bbuild -G Ninja -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=/usr/bin/gcc -DCMAKE_CXX_COMPILER=/usr/bin/g++
run: cmake -S . -Bbuild -G Ninja -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=/usr/bin/clang -DCMAKE_CXX_COMPILER=/usr/bin/clang++
- name: Run include-what-you-use
run: |
iwyu_tool -p build/compile_commands.json -j${{env.linux-vcpus}} | tee includes.txt
Expand Down
Loading
Loading