Skip to content

CI: Use CaDiCaL on Windows #8422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tautschnig
Copy link
Collaborator

We should also build solvers others than MiniSat on Windows.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Aug 21, 2024
We should also build solvers others than MiniSat on Windows.
@tautschnig
Copy link
Collaborator Author

Closing as we'd have to use https://github.com/sfiruch/cadical/, which will incur further maintenance overhead.

@tautschnig tautschnig closed this Aug 21, 2024
@tautschnig tautschnig deleted the win-ci-use-cadical branch August 21, 2024 10:00
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.85%. Comparing base (dae5af0) to head (b3f85f4).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8422   +/-   ##
========================================
  Coverage    77.85%   77.85%           
========================================
  Files         1726     1726           
  Lines       189886   189886           
  Branches     18223    18223           
========================================
  Hits        147835   147835           
  Misses       42051    42051           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant